Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _data attribute from DataSampler #328

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Remove _data attribute from DataSampler #328

merged 4 commits into from
Jan 24, 2024

Conversation

fealho
Copy link
Member

@fealho fealho commented Jan 22, 2024

CU-86az1bfrb, Resolve #327.

@sdv-team
Copy link
Contributor

@fealho fealho marked this pull request as ready for review January 23, 2024 00:37
@fealho fealho requested a review from a team as a code owner January 23, 2024 00:37
@fealho fealho requested review from rwedge and frances-h and removed request for a team January 23, 2024 00:37
ctgan/data_sampler.py Outdated Show resolved Hide resolved
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor documentation comment

@fealho fealho merged commit 39cfbbe into main Jan 24, 2024
45 checks passed
@fealho fealho deleted the issue-327-datasampler branch January 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve DataSampler efficiency
4 participants