Add support for python 3.11 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is waiting on SDV and SDMetrics releases with python 3.11. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 48.05% 48.05%
=======================================
Files 19 19
Lines 1155 1155
=======================================
Hits 555 555
Misses 600 600 ☔ View full report in Codecov by Sentry. |
amontanez24
approved these changes
Aug 16, 2023
tests/integration/test_benchmark.py
Outdated
| @@ -211,7 +211,7 @@ def sample_from_synthesizer(synthesizer, n_samples): | |||
| pd.testing.assert_series_equal(results['Synthesizer'], expected_synthesizers) | |||
|
|
|||
| assert set(results['Dataset']) == {'fake_companies'} | |||
| assert set(results['Dataset_Size_MB']) == {0.00128} | |||
| assert set(round(results['Dataset_Size_MB'], 5)) == {.00128} | |||
There was a problem hiding this comment.
minor: alternatively you could use
assert np.isclose(a, b)I think that seems more clear than rounding
frances-h
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #250.