-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python 3.11 #256
Conversation
PR is waiting on SDV and SDMetrics releases with python 3.11. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 48.05% 48.05%
=======================================
Files 19 19
Lines 1155 1155
=======================================
Hits 555 555
Misses 600 600 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tests/integration/test_benchmark.py
Outdated
@@ -211,7 +211,7 @@ def sample_from_synthesizer(synthesizer, n_samples): | |||
pd.testing.assert_series_equal(results['Synthesizer'], expected_synthesizers) | |||
|
|||
assert set(results['Dataset']) == {'fake_companies'} | |||
assert set(results['Dataset_Size_MB']) == {0.00128} | |||
assert set(round(results['Dataset_Size_MB'], 5)) == {.00128} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: alternatively you could use
assert np.isclose(a, b)
I think that seems more clear than rounding
Resolve #250.