Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align default transformers between SDV and RDT #1506

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Align default transformers between SDV and RDT #1506

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68e7f25
use rdt default transformers
R-Palazzo Jul 17, 2023
580654a
fix minimum version
R-Palazzo Jul 18, 2023
d84def8
test
R-Palazzo Jul 19, 2023
518675c
pomegranate 1
R-Palazzo Jul 19, 2023
9a01726
change assert test
R-Palazzo Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions tests/unit/data_processing/test_data_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,17 @@ def test___init__(
metadata.add_alternate_keys(['col_2'])
metadata.set_primary_key('col')

mock_default_transformers.return_value = {
'numerical': 'FloatFormatter()',
'categorical': 'LabelEncoder(add_noise=True)',
'boolean': 'LabelEncoder(add_noise=True)',
'datetime': 'UnixTimestampEncoder()',
'text': 'RegexGenerator()',
'pii': 'AnonymizedFaker()',
}

mock_regex_generator.return_value = 'RegexGenerator()'

# Run
data_processor = DataProcessor(
metadata=metadata,
Expand Down Expand Up @@ -100,6 +111,18 @@ def test___init__(
mock_default_transformers.assert_called_once()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should mock the return value and make sure the id default is properly added and that the text one is deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes done in d84def8

mock_regex_generator.assert_called_once()

expected_default_transformers = {
'numerical': 'FloatFormatter()',
'categorical': 'LabelEncoder(add_noise=True)',
'boolean': 'LabelEncoder(add_noise=True)',
'datetime': 'UnixTimestampEncoder()',
'id': 'RegexGenerator()',
'pii': 'AnonymizedFaker()',
}
assert 'text' not in data_processor._transformers_by_sdtype
assert 'id' in data_processor._transformers_by_sdtype
assert data_processor._transformers_by_sdtype == expected_default_transformers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last assert is probably all you need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done in 9a01726


def test___init___without_mocks(self):
"""Test the ``__init__`` method without using mocks.

Expand Down