-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align default transformers between SDV and RDT #1506
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,13 +43,20 @@ def test__update_numerical_transformer(self): | |
assert transformer.learn_rounding_scheme is False | ||
assert transformer.enforce_min_max_values is False | ||
|
||
@patch('sdv.data_processing.data_processor.rdt.transformers.RegexGenerator') | ||
@patch('sdv.data_processing.data_processor.get_default_transformers') | ||
@patch('sdv.data_processing.data_processor.rdt') | ||
@patch('sdv.data_processing.data_processor.DataProcessor._update_numerical_transformer') | ||
def test___init__(self, update_transformer_mock, mock_rdt): | ||
def test___init__( | ||
self, update_transformer_mock, mock_rdt, mock_default_transformers, mock_regex_generator | ||
): | ||
"""Test the ``__init__`` method. | ||
|
||
Setup: | ||
- Patch the ``Constraint`` module. | ||
- Patch the ``RegexGenerator`` class. | ||
- Patch the ``get_default_transformers`` function. | ||
- Patch the ``rdt`` module. | ||
- Patch the ``_update_numerical_transformer`` method. | ||
|
||
Input: | ||
- A mock for metadata. | ||
|
@@ -63,6 +70,17 @@ def test___init__(self, update_transformer_mock, mock_rdt): | |
metadata.add_alternate_keys(['col_2']) | ||
metadata.set_primary_key('col') | ||
|
||
mock_default_transformers.return_value = { | ||
'numerical': 'FloatFormatter()', | ||
'categorical': 'LabelEncoder(add_noise=True)', | ||
'boolean': 'LabelEncoder(add_noise=True)', | ||
'datetime': 'UnixTimestampEncoder()', | ||
'text': 'RegexGenerator()', | ||
'pii': 'AnonymizedFaker()', | ||
} | ||
|
||
mock_regex_generator.return_value = 'RegexGenerator()' | ||
|
||
# Run | ||
data_processor = DataProcessor( | ||
metadata=metadata, | ||
|
@@ -90,6 +108,20 @@ def test___init__(self, update_transformer_mock, mock_rdt): | |
assert data_processor._hyper_transformer == mock_rdt.HyperTransformer.return_value | ||
update_transformer_mock.assert_called_with(True, False) | ||
|
||
mock_default_transformers.assert_called_once() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should mock the return value and make sure the id default is properly added and that the text one is deleted There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes done in d84def8 |
||
mock_regex_generator.assert_called_once() | ||
|
||
expected_default_transformers = { | ||
'numerical': 'FloatFormatter()', | ||
'categorical': 'LabelEncoder(add_noise=True)', | ||
'boolean': 'LabelEncoder(add_noise=True)', | ||
'datetime': 'UnixTimestampEncoder()', | ||
'id': 'RegexGenerator()', | ||
'pii': 'AnonymizedFaker()', | ||
} | ||
|
||
assert data_processor._transformers_by_sdtype == expected_default_transformers | ||
|
||
def test___init___without_mocks(self): | ||
"""Test the ``__init__`` method without using mocks. | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you leave a comment in the description of the PR explaining why we made this change and the one on line 74? If we're going to merge this in this PR it would be good to understand why