Cannot create custom constraint with primary key #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
requested review from
fealho and
frances-h
and removed request for
a team
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
+ Coverage 96.28% 96.36% +0.07%
==========================================
Files 49 49
Lines 3934 3936 +2
==========================================
+ Hits 3788 3793 +5
+ Misses 146 143 -3
☔ View full report in Codecov by Sentry. |
fealho
approved these changes
Jul 29, 2023
| @@ -1821,7 +1822,7 @@ def test__transform_constraints_is_condition_false_returns_data(self): | |||
| assert result.equals(expected_result) | |||
| assert dp._constraints_to_reverse == [] | |||
|
|
|||
| def test_reverse_transform(self): | |||
| def test_reverse_transform_blah(self): | |||
There was a problem hiding this comment.
lol thanks I forgot about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1514