parser: support empty list for DTB selection #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
changed the title
axel-h
force-pushed
the
patch-axel-5
branch
2 times, most recently
from
8b319a5
to
70e3e8f
Compare
axel-h
force-pushed
the
patch-axel-5
branch
2 times, most recently
from
e16f01a
to
cf897cc
Compare
added 3 commits
July 2, 2024 12:25
Also drop the comments, because one is misleading and the other one just states what is obvious. Signed-off-by: Axel Heider <[email protected]>
Signed-off-by: Axel Heider <[email protected]>
This is for convenience reasons, as it allows using `vm0.dtb = dtb([])`
instead of `dtb([{}]);` with a dummy element.
Signed-off-by: Axel Heider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using
vm0.dtb = dtb([]);because an empty list seems a bit more intuitive than having to use a dummy elementvm0.dtb = dtb([{}]);Test with: seL4/camkes-vm-examples#36