Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CHANGES file #145

Merged
merged 3 commits into from
Jul 1, 2024
Merged

update CHANGES file #145

merged 3 commits into from
Jul 1, 2024

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Jun 24, 2024

  • rename file to CHANGES.md for GitHub rendering (will need an update in release scripts)
  • improve markdown compliance and consistency
  • add changes for upcoming release

This is probably easiest reviewed by commit. The last commit should be the only one with content changes, the rest is just reformatting, indenting and header-level change.

so that GitHub properly renders the file as markdown.

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 force-pushed the lsf37/changes branch 2 times, most recently from 170eab2 to f1023b8 Compare June 24, 2024 14:10
@lsf37 lsf37 requested a review from kent-mcleod June 24, 2024 14:18
@lsf37 lsf37 self-assigned this Jun 24, 2024
@lsf37 lsf37 force-pushed the lsf37/changes branch 2 times, most recently from 95b23c8 to 163f1c8 Compare June 27, 2024 00:33
@lsf37 lsf37 requested a review from ikuz June 27, 2024 00:34
@lsf37
Copy link
Member Author

lsf37 commented Jun 27, 2024

Hey @kent-mcleod or @ikuz, could you give this a quick review before the end of the week so we can publish the release on Mon?

Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to look good. Suggestion for middle commit: the word "consistent" is spelled two different ways :)

lsf37 added 2 commits July 1, 2024 11:38
Make sure text is rendered correctly on different markdown engines.

- avoid bare URLs
- consistent list indent and spacing
- consistent heading style
- use level-2 head for release

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 merged commit cfa9e60 into master Jul 1, 2024
24 of 25 checks passed
@lsf37 lsf37 deleted the lsf37/changes branch July 1, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants