Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camkes-deps: fully remove orderedset; bump version #147

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Jun 30, 2024

  • commit 4f7bca1 replaced orderedset by the maintained ordered-set, but did no yet remove the dependency. Since on more recent python version the dependency install now fails, we are removing it completely.

  • make python 3 requirement explicit

To be released on PyPi simultaneously with the upcoming CAmkES release.

Closes #124

@lsf37 lsf37 self-assigned this Jun 30, 2024
@lsf37 lsf37 requested a review from axel-h June 30, 2024 01:52
@lsf37
Copy link
Member Author

lsf37 commented Jun 30, 2024

Have added an ignore rule for the link checker for the jinja link that now produces 403 unless viewed through a browser. All those DDOS protections are going to lead to a lot of dead links in the interwebs.

@lsf37 lsf37 mentioned this pull request Jun 30, 2024
@lsf37 lsf37 requested a review from wom-bat June 30, 2024 23:51
lsf37 added 2 commits July 1, 2024 12:48
- commit 4f7bca1 replaced orderedset by the maintained ordered-set,
but did no yet remove the dependency. Since on more recent python
version the dependency install now fails, we are removing it completely.

- make python 3 requirement explicit

To be released on PyPi simultaneously with the next CAmkES release.

Closes #124

Signed-off-by: Gerwin Klein <[email protected]>
http://jinja.pocoo.org/docs/ produces 403 for the link checker, but
works in the browser.

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 merged commit c77562e into master Jul 1, 2024
25 checks passed
@lsf37 lsf37 deleted the lsf37/ordered-set branch July 1, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove orderedset from camkes-deps
2 participants