Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sel4bench: remove HARDWARE and FAULT for hifive #215

Merged
merged 1 commit into from
Jul 11, 2022
Merged

sel4bench: remove HARDWARE and FAULT for hifive #215

merged 1 commit into from
Jul 11, 2022

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Jul 7, 2022

See #203 and seL4/sel4bench#20 for background.

@lsf37 lsf37 self-assigned this Jul 7, 2022
@lsf37 lsf37 added the benchmarking sel4bench and related actions label Jul 7, 2022
@lsf37 lsf37 requested a review from axel-h July 7, 2022 22:34
@lsf37 lsf37 linked an issue Jul 7, 2022 that may be closed by this pull request
adjust sel4bench parameters for hifive #203
Closed
axel-h
axel-h approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. I've read through the threads, maybe adding a comment that captures the essence could be helpful for the long run, so the python code checks can be understood without digging through the PR/issue history.

@lsf37
sel4bench: remove HARDWARE and FAULT for hifive
d4768f4 
See #203 and seL4/sel4bench#20 for background.

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37
Copy link
Member Author

lsf37 commented Jul 11, 2022

Looks ok to me. I've read through the threads, maybe adding a comment that captures the essence could be helpful for the long run, so the python code checks can be understood without digging through the PR/issue history.

Fair enough, I've added the PR discussion link as a comment.

@lsf37 lsf37 merged commit 761ee54 into master Jul 11, 2022
@lsf37 lsf37 deleted the adjust-hifive branch July 11, 2022 01:22
@axel-h axel-h mentioned this pull request Jul 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel-h axel-h axel-h approved these changes

@kent-mcleod kent-mcleod kent-mcleod approved these changes

Assignees

@lsf37 lsf37

Labels
benchmarking sel4bench and related actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjust sel4bench parameters for hifive
3 participants
@lsf37 @kent-mcleod @axel-h