user.sh: put env settings in /etc/bash.bashrc #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user home is a docker volume, which is persistent between container runs and cannot be mounted during image building. Store env settings like PATH and other variables in container-global /etc/bash.bashrc instead of user ~/.bashrc so that changes to these variables during image build become visible without deleting the volume. Signed-off-by: Gerwin Klein <[email protected]>
Ivan-Velickovic
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user home is a docker volume, which is persistent between container runs and cannot be mounted during image building.
Store env settings like PATH and other variables in container-global /etc/bash.bashrc instead of user ~/.bashrc so that changes to these variables during image build become visible without deleting the volume.
One example where that is necessary is the recent change to
ghcup-- those settings don't become visible for users who already have a user-home volume set up.