Improve portability of arch detection in Makefile #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'uname -m' is more portable than 'arch'. Signed-off-by: Nick Spinale <[email protected]>
nspin
force-pushed
the
pr/portable-arch-detection
branch
from
05b7835
to
9f31951
Compare
Ivan-Velickovic
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
arch seems to exist on Debian/Ubuntu but I agree that uname -m is more portable.
@lsf37 do you know what's going up with the Apple Silicon build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
archis MacOS-specific.uname -mis more portable.