Skip to content

Commit

Permalink
Removed pauses between iterations
Browse files Browse the repository at this point in the history
After a discussion on the PR, I tested to see whether the pauses
which I had between iterations on some benchmarks made a notable
difference. After testing on odroidc2 MCS/non-MCS, which was the
platform that I observed these issues on which lead to me adding
the pause, I found that there was no significant difference
without the pause so I have removed them.

Signed-off-by: Alwin Joshy <[email protected]>
  • Loading branch information
alwin-joshy committed Feb 28, 2023
1 parent 8b54555 commit 9bec647
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
10 changes: 0 additions & 10 deletions apps/fault/src/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ static void measure_vm_fault_handler_fn(int argc, char **argv)

parse_handler_args(argc, argv, &ep, &start, &results, &done_ep, &reply, &tcb);

seL4_Word junk;

/* signal driver to convert us to passive and block */
if (config_set(CONFIG_KERNEL_MCS)) {
api_nbsend_recv(done_ep, seL4_MessageInfo_new(0, 0, 0, 0), ep, NULL, reply);
Expand All @@ -210,10 +208,6 @@ static void measure_vm_fault_handler_fn(int argc, char **argv)
DO_REAL_REPLY_RECV_1(ep, msg, reply);
SEL4BENCH_READ_CCNT(end);
results->vm_fault[i] = end - *start;
volatile int j;
for (j = 0; j < 10000; j++) {

}
}

set_good_magic_and_set_pc(tcb, (seL4_Word)read_fault_restart_address);
Expand Down Expand Up @@ -373,10 +367,6 @@ static void measure_fault_roundtrip_fn(int argc, char **argv)
fault();
SEL4BENCH_READ_CCNT(end);
results->round_trip[i] = end - start;
volatile int j;
for (j = 0; j < 10000; j++) {

}
}
seL4_Send(done_ep, seL4_MessageInfo_new(0, 0, 0, 0));
}
Expand Down
2 changes: 1 addition & 1 deletion easy-settings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# ninja
#
set(RELEASE ON CACHE BOOL "Performance optimized build")
set(PLATFORM "x86_64" CACHE STRING "Platform to test")
set(PLATFORM "odroidc2" CACHE STRING "Platform to test")
set(FASTPATH ON CACHE BOOL "Turn fastpath on or off")
set(ARM_HYP OFF CACHE BOOL "ARM EL2 hypervisor features on or off")
set(MCS OFF CACHE BOOL "MCS kernel")
Expand Down

0 comments on commit 9bec647

Please sign in to comment.