Use consistent variable name

sebastianbergmann · Dec 11, 2024 · 2ad0441 · 2ad0441
1 parent 7195d43
commit 2ad0441
Show file tree

Hide file tree

Showing 8 changed files with 138 additions and 138 deletions.
diff --git a/tests/unit/Framework/MockObject/Creation/CreateConfiguredMockTest.php b/tests/unit/Framework/MockObject/Creation/CreateConfiguredMockTest.php
@@ -24,15 +24,15 @@ final class CreateConfiguredMockTest extends TestCase
 {
     public function testCreatesMockObjectForInterfaceOrExtendableClassWithReturnValueConfigurationForMultipleMethods(): void
     {
-        $stub = $this->createConfiguredMock(
+        $double = $this->createConfiguredMock(
             InterfaceWithReturnTypeDeclaration::class,
             [
                 'doSomething'     => true,
                 'doSomethingElse' => 1,
             ],
         );
 
-        $this->assertTrue($stub->doSomething());
-        $this->assertSame(1, $stub->doSomethingElse(0));
+        $this->assertTrue($double->doSomething());
+        $this->assertSame(1, $double->doSomethingElse(0));
     }
 }
diff --git a/tests/unit/Framework/MockObject/Creation/CreateConfiguredStubTest.php b/tests/unit/Framework/MockObject/Creation/CreateConfiguredStubTest.php
@@ -24,15 +24,15 @@ final class CreateConfiguredStubTest extends TestCase
 {
     public function testCreatesTestStubForInterfaceOrExtendableClassWithReturnValueConfigurationForMultipleMethods(): void
     {
-        $stub = $this->createConfiguredStub(
+        $double = $this->createConfiguredStub(
             InterfaceWithReturnTypeDeclaration::class,
             [
                 'doSomething'     => true,
                 'doSomethingElse' => 1,
             ],
         );
 
-        $this->assertTrue($stub->doSomething());
-        $this->assertSame(1, $stub->doSomethingElse(0));
+        $this->assertTrue($double->doSomething());
+        $this->assertSame(1, $double->doSomethingElse(0));
     }
 }
diff --git a/tests/unit/Framework/MockObject/Creation/CreatePartialMockTest.php b/tests/unit/Framework/MockObject/Creation/CreatePartialMockTest.php
@@ -26,11 +26,11 @@ final class CreatePartialMockTest extends TestCase
 {
     public function testCreatesPartialMockObjectForExtendableClass(): void
     {
-        $mock = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
+        $double = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
 
-        $mock->expects($this->once())->method('doSomethingElse')->willReturn(true);
+        $double->expects($this->once())->method('doSomethingElse')->willReturn(true);
 
-        $this->assertTrue($mock->doSomething());
+        $this->assertTrue($double->doSomething());
     }
 
     public function testCannotCreatePartialMockObjectForExtendableClassWithDuplicateMethods(): void
@@ -43,10 +43,10 @@ public function testCannotCreatePartialMockObjectForExtendableClassWithDuplicate
 
     public function testMethodOfPartialMockThatIsNotConfigurableCannotBeConfigured(): void
     {
-        $mock = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
+        $double = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
 
         try {
-            $mock->expects($this->once())->method('doSomething')->willReturn(true);
+            $double->expects($this->once())->method('doSomething')->willReturn(true);
         } catch (MethodCannotBeConfiguredException $e) {
             $this->assertSame('Trying to configure method "doSomething" which cannot be configured because it does not exist, has not been specified, is final, or is static', $e->getMessage());
 

diff --git a/tests/unit/Framework/MockObject/Creation/CreateTestProxyTest.php b/tests/unit/Framework/MockObject/Creation/CreateTestProxyTest.php
@@ -25,14 +25,14 @@ final class CreateTestProxyTest extends TestCase
 {
     public function testCreatesTestProxyForExtendableClass(): void
     {
-        $proxy = $this->createTestProxy(TestProxyFixture::class);
+        $double = $this->createTestProxy(TestProxyFixture::class);
 
-        $proxy->expects($this->once())
+        $double->expects($this->once())
             ->method('returnString');
 
-        assert($proxy instanceof MockObject);
-        assert($proxy instanceof TestProxyFixture);
+        assert($double instanceof MockObject);
+        assert($double instanceof TestProxyFixture);
 
-        $this->assertSame('result', $proxy->returnString());
+        $this->assertSame('result', $double->returnString());
     }
 }
diff --git a/tests/unit/Framework/MockObject/Creation/GetMockForAbstractClassTest.php b/tests/unit/Framework/MockObject/Creation/GetMockForAbstractClassTest.php
@@ -28,11 +28,11 @@ final class GetMockForAbstractClassTest extends TestCase
 {
     public function testCreatesMockObjectForAbstractClassAndAllowsConfigurationOfAbstractMethods(): void
     {
-        $mock = $this->getMockForAbstractClass(AbstractClass::class);
+        $double = $this->getMockForAbstractClass(AbstractClass::class);
 
-        $mock->expects($this->once())->method('doSomethingElse')->willReturn(true);
+        $double->expects($this->once())->method('doSomethingElse')->willReturn(true);
 
-        $this->assertTrue($mock->doSomething());
+        $this->assertTrue($double->doSomething());
     }
 
     public function testCannotCreateMockObjectForAbstractClassThatDoesNotExist(): void
@@ -45,10 +45,10 @@ public function testCannotCreateMockObjectForAbstractClassThatDoesNotExist(): vo
 
     public function testCreatesMockObjectForAbstractClassAndDoesNotAllowConfigurationOfConcreteMethods(): void
     {
-        $mock = $this->getMockForAbstractClass(AbstractClass::class);
+        $double = $this->getMockForAbstractClass(AbstractClass::class);
 
         try {
-            $mock->expects($this->once())->method('doSomething');
+            $double->expects($this->once())->method('doSomething');
         } catch (MethodCannotBeConfiguredException $e) {
             $this->assertSame('Trying to configure method "doSomething" which cannot be configured because it does not exist, has not been specified, is final, or is static', $e->getMessage());
 

diff --git a/tests/unit/Framework/MockObject/Creation/GetMockForTraitTest.php b/tests/unit/Framework/MockObject/Creation/GetMockForTraitTest.php
@@ -25,11 +25,11 @@ final class GetMockForTraitTest extends TestCase
 {
     public function testCreatesMockObjectForTraitAndAllowsConfigurationOfAbstractMethods(): void
     {
-        $mock = $this->getMockForTrait(TraitWithConcreteAndAbstractMethod::class);
+        $double = $this->getMockForTrait(TraitWithConcreteAndAbstractMethod::class);
 
-        $mock->method('abstractMethod')->willReturn(true);
+        $double->method('abstractMethod')->willReturn(true);
 
-        $this->assertTrue($mock->concreteMethod());
+        $this->assertTrue($double->concreteMethod());
     }
 
     public function testCannotCreateMockObjectForTraitThatDoesNotExist(): void

diff --git a/tests/unit/Framework/MockObject/Creation/GetMockFromWsdlTest.php b/tests/unit/Framework/MockObject/Creation/GetMockFromWsdlTest.php
@@ -26,11 +26,11 @@ final class GetMockFromWsdlTest extends TestCase
     #[TestDox('Creates mock object from WSDL file')]
     public function test_CreatesMockObjectFromWsdlFileWithNonNamespacedClassName(): void
     {
-        $mock = $this->getMockFromWsdl(TEST_FILES_PATH . 'GoogleSearch.wsdl');
+        $double = $this->getMockFromWsdl(TEST_FILES_PATH . 'GoogleSearch.wsdl');
 
         $this->assertStringStartsWith(
             'MockObject_GoogleSearch_',
-            $mock::class,
+            $double::class,
         );
     }
 }