Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultResultCache::mergeWith() for merging result cache instances #6081

Merged

Conversation

Slamdunk
Copy link
Contributor

Fix #6078

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (2ad0441) to head (d42717b).
Report is 1 commits behind head on 10.5.

Additional details and impacted files
@@            Coverage Diff            @@
##               10.5    #6081   +/-   ##
=========================================
  Coverage     94.39%   94.40%           
- Complexity     6461     6464    +3     
=========================================
  Files           681      681           
  Lines         20496    20501    +5     
=========================================
+ Hits          19348    19353    +5     
  Misses         1148     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

Can you send this for 10.5? It should also "just work" there and if it does, I'll merge it from there to 11.5 and main. Thanks!

@Slamdunk Slamdunk changed the base branch from main to 10.5 December 11, 2024 10:10
@Slamdunk
Copy link
Contributor Author

Done 😎

@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/test-runner CLI test runner version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 version/12 Something affects PHPUnit 12 labels Dec 11, 2024
@sebastianbergmann sebastianbergmann merged commit e8b3f1b into sebastianbergmann:10.5 Dec 11, 2024
37 checks passed
@Slamdunk Slamdunk deleted the resultcache_merge branch December 11, 2024 10:40
@sebastianbergmann sebastianbergmann changed the title Add DefaultResultCache::mergeWith API to merge multiple result cache instances DefaultResultCache::mergeWith() for merging result cache instances Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-runner CLI test runner type/enhancement A new idea that should be implemented version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 version/12 Something affects PHPUnit 12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DefaultResultCache being able to merge another instance of itself
2 participants