Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic OGV video support #49

Merged
merged 1 commit into from
Sep 8, 2014
Merged

add basic OGV video support #49

merged 1 commit into from
Sep 8, 2014

Conversation

nodiscc
Copy link
Contributor

@nodiscc nodiscc commented Sep 8, 2014

  • work on Video support #46
  • lightbox not supported yet, videos are just linked from the gallery page

This can easily be extended to other video formats, just add filetypes to the Other filetypes section, and symlink their thumbnail (eg. filetype_MKV.png) to to filetype_OGV.png

It would be cool to have videos rendered in the lightbox, but this needs more work and there are current plans to change the lightbox implementation, so I just added basic functionality.

 * work on #46
 * lightbox not supported yet, videos are just linked from the gallery page
@nodiscc
Copy link
Contributor Author

nodiscc commented Sep 8, 2014

Note that it seems possible to generate thumbnails for videos, using php and ffmpeg, see https://stackoverflow.com/questions/25096630/mp4-video-thumbnail-create-using-php-gd, https://github.com/PHP-FFMpeg/PHP-FFMpeg/.

I don't know if this is desirable though (CPU/IO load? Availability of the php-ffmpeg library? Complexity?). I'm fine with just icons for the time being.

Any feedback on this pull request is welcome.

@tmos
Copy link
Collaborator

tmos commented Sep 8, 2014

Great, I merge this :)
As you said, once the lightbox changed, it will probably be possible to add an html5

Thanks for the pull :)

tmos added a commit that referenced this pull request Sep 8, 2014
@tmos tmos merged commit dfadcf8 into sebsauvage:master Sep 8, 2014
@nodiscc
Copy link
Contributor Author

nodiscc commented Sep 8, 2014

thanks @tmos

I'd like to add support for other video types (common formats supported by in-browser player). Maybe common audio formats should be supported too? This way minigal would be a simple multimedia gallery (got the idea from this app)

Is this change welcome?

@nodiscc nodiscc deleted the video-support branch September 8, 2014 16:00
@tmos
Copy link
Collaborator

tmos commented Sep 8, 2014

I'm ok with this, listing more files shouldn't be a problem, as far as you add icons with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants