Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth4LE: BTLE_ADV PDU_type enum typo fix #4620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antoniovazquezblanco
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

The referenced documentation in the code shows a slightly different name. See below.

imagen

@XenoKovah
Copy link

FWIW this isn't actually a typo, the packet used to legitimately be called CONNECT_REQ in BT Core spec <= 4.2, but as of 5.0 they changed it to CONNECT_IND (and we're now on BT Spec 6.0), so it'd just be good to get this synced up with the latest specs.

@antoniovazquezblanco
Copy link
Contributor Author

Oh, makes sense. I went directly to the referenced Core v5.2 in the code and the new name was used...

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants