Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMB: Implement encryption, cleanup RequireSignature #4643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jan 19, 2025

This PR:

  • adds SMB encryption.
  • cleans up how and when signature is required by the client and server, failing in cases where it should fail.

@gpotter2 gpotter2 force-pushed the smb-encryption branch 2 times, most recently from 3b2dd19 to 34c7a43 Compare January 19, 2025 21:51
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 86.11111% with 25 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (92925da) to head (4d98eb5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/smb2.py 90.42% 9 Missing ⚠️
scapy/layers/smbclient.py 72.41% 8 Missing ⚠️
scapy/layers/smbserver.py 86.00% 7 Missing ⚠️
scapy/layers/ntlm.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4643      +/-   ##
==========================================
+ Coverage   80.71%   81.67%   +0.95%     
==========================================
  Files         359      359              
  Lines       86052    86378     +326     
==========================================
+ Hits        69461    70545    +1084     
+ Misses      16591    15833     -758     
Files with missing lines Coverage Δ
scapy/layers/smb.py 76.70% <100.00%> (+0.33%) ⬆️
scapy/layers/ntlm.py 87.31% <50.00%> (+0.02%) ⬆️
scapy/layers/smbserver.py 72.81% <86.00%> (+1.84%) ⬆️
scapy/layers/smbclient.py 74.02% <72.41%> (-0.37%) ⬇️
scapy/layers/smb2.py 88.19% <90.42%> (+0.90%) ⬆️

... and 28 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant