-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] ggml: add model not found test #130
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Based on the individual summaries provided for each code patch in the GitHub Pull Request titled "[Example] ggml: add model not found test," several potential issues and important findings have been identified: Potential Issues and Errors:
Important Findings:
In conclusion, while the changes in the PR appear to enhance the DetailsCommit 5837fba9b5dd53e063742d13139cd8e30698a5d6Key Changes:
Potential Problems:
Overall, the changes look good, but the potential problems should be addressed before merging the pull request. Commit eef9036d59f536209829eda590773f3fbfd29efbKey Changes:
Potential Problems:
Overall, the patch appears to be a routine update to a dependency version, but verification through testing is recommended to ensure the stability and correctness of the Commit 4a38db92521e58bd63424447127c97f36da234a2Key Changes:
Potential Problems:
|
Signed-off-by: dm4 <[email protected]>
9395ff3
to
ca92d07
Compare
ca92d07
to
5837fba
Compare
Signed-off-by: dm4 <[email protected]>
Signed-off-by: dm4 <[email protected]>
905a5af
to
4a38db9
Compare
To add
ModelNotFound
error towasmedge-wasi-nn
and use it in our WasmEdge WASINN examples, we need:In this PR, I also update the
wasmedge-wasi-nn
to the latest version 0.7.1 and add the unload test for testing unload and reload the graph multiple times.