-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] simplify llama examples #92
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Summary: Overall, there are several potential issues and errors in this GitHub Pull Request. The patch introduces a significant number of changes, which can make it difficult to understand the overall impact and may lead to confusion for users. Additionally, some changes, such as the deletion of the The most important findings in this review include the need for clearer explanations and alternatives for the changes made, proper documentation and tests to ensure the changes are well-documented and tested, and providing context and explanations for the new build steps added. It is crucial to address these issues to improve the quality and understandability of the code changes. DetailsCommit 8d97175955b7489884049417f90bcc55dcf73e78Key changes:
Potential problems:
Commit 1daefb910a1b4537644db33daf30a950e16eeb9dKey changes:
Potential problems:
Commit 5b0dfeced22074296e412d9f8d0ed2361d3638d2Key changes:
Potential problems:
Overall, the key changes in this patch involve rearranging the project structure by moving the Commit 4676d2c6681fc215b7e0da3e8eb80ea0ed03c33dKey changes in the patch:
Potential problems:
Overall, it would be beneficial to provide more context and documentation for the changes introduced by this patch. This would help reviewers and other contributors understand the rationale behind the changes and ensure that they have been implemented correctly. |
Signed-off-by: dm4 <[email protected]>
Signed-off-by: dm4 <[email protected]>
Signed-off-by: dm4 <[email protected]>
87583b7
to
b453795
Compare
Signed-off-by: dm4 <[email protected]>
Simplify llama examples, split it into:
All of these are under
wasmedge-ggml
directory.