Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] ggml: update gemma example for stream output #99

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

dm4
Copy link
Member

@dm4 dm4 commented Feb 22, 2024

  • Update gemma example for stream output

Copy link
Member

juntao commented Feb 22, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit b0b43c505daa64edf9545aa68cba0ac5ad968462

Key changes in the patch:

  1. Update the main.rs file in the wasmedge-ggml/gemma directory.
  2. Update the example to handle stream output with the addition of conditions for printing "USER:" and "ASSISTANT:" messages.

Potential problems:

  1. The code changes are straightforward, focusing on updating the message prompts for user and assistant. However, the changes might be more meaningful if they were supplemented with some comments explaining the purpose of these updates.
  2. The condition for printing an empty line when the "stream-stdout" option is enabled might cause confusion if not adequately documented. Reviewers could suggest adding comments to clarify the purpose of this condition.
  3. The binary patch in the wasmedge-ggml-gemma.wasm file might need further investigation to ensure that the changes align with the expected code modifications. This could involve running tests to verify the functionality of the changed wasm file.
  4. It's always good practice to ensure that the code formatting and style are consistent with the project's guidelines. Reviewers could check if the new code follows the project's style guide.

@dm4 dm4 force-pushed the dm4/gemma-stream-stdout branch from cfd5eeb to b0b43c5 Compare February 22, 2024 05:24
@dm4 dm4 requested a review from hydai February 22, 2024 05:24
@hydai hydai merged commit a3b0685 into dev Feb 22, 2024
3 checks passed
@hydai hydai deleted the dm4/gemma-stream-stdout branch February 22, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants