Make killAllFlows() kill flows (#682)

secure-software-engineering · Nov 25, 2023 · fc14480 · fc14480
1 parent 3aca432
commit fc14480
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/include/phasar/DataFlow/IfdsIde/FlowFunctions.h b/include/phasar/DataFlow/IfdsIde/FlowFunctions.h
@@ -107,14 +107,14 @@ class ZeroedFlowFunction : public FlowFunction<D, Container> {
 
 public:
   ZeroedFlowFunction(FlowFunctionPtrType FF, D ZV)
-      : Delegate(std::move(FF)), ZeroValue(ZV) {}
+      : Delegate(std::move(FF)), ZeroValue(std::move(ZV)) {}
   container_type computeTargets(D Source) override {
     if (Source == ZeroValue) {
       container_type Result = Delegate->computeTargets(Source);
       Result.insert(ZeroValue);
       return Result;
     }
-    return Delegate->computeTargets(Source);
+    return Delegate->computeTargets(std::move(Source));
   }
 
 private:
@@ -423,9 +423,7 @@ template <typename D, typename Container> class FlowFunctionTemplates {
   ///
   static auto killAllFlows() {
     struct KillAllFF final : public FlowFunction<d_t, container_type> {
-      Container computeTargets(d_t Source) override {
-        return {std::move(Source)};
-      }
+      Container computeTargets(d_t /*Source*/) override { return Container(); }
     };
     static auto TheKillAllFlow = std::make_shared<KillAllFF>();