Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backward ICFG #660

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Fix Backward ICFG #660

merged 8 commits into from
Sep 21, 2023

Conversation

fabianbs96
Copy link
Member

Currently the backward ICFG cannot be used as it lacks the implementation of some required interface functions.
This PR adds this functionality by forwarding to LLVMBasedICFG.
In addition, we use explicit template instantiation to enable detecting such issues earlier.

…nted) + use explicit template instantiation to make sure, the interface is fully implemented in the future
@fabianbs96 fabianbs96 added the bug Something isn't working label Aug 18, 2023
@fabianbs96 fabianbs96 self-assigned this Aug 18, 2023
@fabianbs96 fabianbs96 marked this pull request as ready for review August 28, 2023 17:32
@fabianbs96 fabianbs96 requested a review from MMory as a code owner August 28, 2023 17:32
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@MMory MMory merged commit 94a0e47 into development Sep 21, 2023
4 checks passed
@MMory MMory deleted the f-FixBackwardICFG branch September 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants