Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't link fat LLVM lib in myphasartool, needs to be transitively pulled in through phasar #663

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Don't link fat LLVM lib in myphasartool, needs to be transitively pulled in through phasar #663

merged 2 commits into from
Aug 28, 2023

Conversation

MMory
Copy link
Member

@MMory MMory commented Aug 28, 2023

No description provided.

@MMory MMory requested a review from fabianbs96 as a code owner August 28, 2023 10:07
@MMory MMory removed the request for review from fabianbs96 August 28, 2023 10:07
vulder
vulder approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the linking be really required, we should put it behind a USE_FAT lib check

@vulder vulder requested a review from fabianbs96 August 28, 2023 11:01
fabianbs96
fabianbs96 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@fabianbs96 fabianbs96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabianbs96 fabianbs96 merged commit 1d0b6e4 into development Aug 28, 2023
4 checks passed
@fabianbs96 fabianbs96 deleted the f-DontLinkFatLLVMinexample branch August 28, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vulder vulder vulder approved these changes

@fabianbs96 fabianbs96 fabianbs96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MMory @vulder @fabianbs96