Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds helper function to determine if a function was generated by phasar #665

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

vulder
Copy link
Collaborator

@vulder vulder commented Sep 4, 2023

During global analysis, phasar generates helper function to correctly handle global ctors/dtors and other global code fragments. With the new checking function, users can determine whether a given function was generated by phasar or not, e.g., for global analysis.

During global analysis, phasar generates helper function to correctly
handle global ctors/dtors and other global code fragments. With the new
checking function, users can determine whether a given function was
generated by phasar or not, e.g., for global analysis.
@MMory
Copy link
Member

MMory commented Sep 4, 2023

In the course of this we should use consts instead of magic string literals. Somewhere we use them, somewhere we don't. I'm gonna make a commit in this branch to fix this.

@MMory
Copy link
Member

MMory commented Sep 6, 2023

@vulder @fabianbs96 could you have a look at the changes I just committed?

@vulder
Copy link
Collaborator Author

vulder commented Sep 7, 2023

Looks good overall, let's merge this

Copy link
Member

@fabianbs96 fabianbs96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabianbs96 fabianbs96 merged commit 76fe080 into development Sep 10, 2023
4 checks passed
@fabianbs96 fabianbs96 deleted the f-IsGenerated branch September 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants