New Python rule checks for ssl use with no timeout #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ssl.get_server_certificate function has a timeout parameter that defaults to the global timeout which itself defaults to None. When the value is None, the socket blocks forever. Note: the timeout parameter wasn't added till Python 3.10. To fix this on earlier Python versions, someone would need to adjust the global timeout value. PY046 Signed-off-by: Eric Brown <[email protected]>
ericwb
force-pushed
the
ssl_no_timeout
branch
from
7c36612 to
dee52c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ssl.get_server_certificate function has a timeout parameter that defaults to the global timeout which itself defaults to None. When the value is None, the socket blocks forever.
Note: the timeout parameter wasn't added till Python 3.10. To fix this on earlier Python versions, someone would need to adjust the global timeout value.
PY046