-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #10
Minor fixes #10
Conversation
Text says that `update` function returns `Update` struct. But in the code example it actually doesn't. I'm not yet sure how to fix it.
There are links to API docs in the text but
|
|
|
Sure. Note that you can push to my branch with your own changes. |
Say when ready, and we'll merge this. These fixes are great. |
Sure, I'm slowly reading through the docs, so when I'll finish I'll leave a comment. |
Ok, I think this PR can be squashed and merged. |
It sounds like a bug, |
Hm, I can't see the difference anymore. Either some caching problem or just my misunderstanding. fetch.md has an |
I don't see any differences. Maybe it's really a problem with cache.
If it works for you now, please create a new issue like "Implement cache busting" in quickstart-webpack repo. |
Sorry, I wasn't clear enough. What I mean when I asked to take a look is that code example itself if staled. |
@TatriX Yeah, thanks for the explanation. |
Well, I would do that with help of |
Some ideas here: #11. We should continue discussion in that issue. |
Hi!
I was readining a new version of the guide and noticed several possible minor issues.
I'll put proposed changes here.