-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/seed 0.7.0 #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Btw I didn't have a feel that C!
is fighting with C
while I was reading code.
There is a lot of “cognitive complexity” that Clippy complains about. |
I'm ok with some global Clippy allows in this project - Seed repo should be clean, but it's not so critical here. Try to resolve my previous comments if possible, but don't kill time with too much refactoring here. |
Are there any other changes in API that I forgot to apply?
|
Clippy complains about seed-rs.org/crate/src/page/partial/intro.rs Line 199 in 6e6a495
seed-rs.org/crate/src/page/guide.rs Line 8 in 6e6a495
seed-rs.org/crate/src/page/guide.rs Line 26 in 6e6a495
I will disable |
Perhaps we should export these things in prelude.
|
Cargo.lock was bound to local seed repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Please merge and check if I didn't break something - https://github.com/akhilman/seed-rs.org/pull/1, thanks!
Update/seed 0.7.0 2 Changes: - Updated Rust and JS deps. - Doesn't show warnings in webpack-dev-server overlay (to resolve unnecessary warning). - Updated architecture according to Seed's example `pages` (removed `Route`, use struct `Urls`, etc.) - Replaced url part `/seed/latest` with `seed/0.6.0` in all guides so the links won't be broken by new Seed release. - Removed `optimize_wasm.js` script because `wasm-pack` calls `wasm-opt` automatically in recent versions. - Removed `package.json` because we use `Yarn`. - Get rid of the error caused by tests configured to be used only with NodeJS.
Upgrading to current seed's master.
Fixes #43