Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust repo linting and formatting config #1077

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Adjust repo linting and formatting config #1077

merged 2 commits into from
Nov 14, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Nov 8, 2024

A few tweaks to our eslint and prettier configs to hopefully prevent lint failures:

  • Remove unnecessary */* from some .eslintignore entries
  • Ignore sku-generated files in fixtures from prettier. These files can sometimes cause the lint script to fail, but really we should ignore them.
  • Pass --cache-location to eslint in format script. We are already setting a cache location in the lint script, but without setting the same location during eslint --fix, the cache is not respected. Without this, a .eslintcache file is generated in the repo root in addition to the one in node_modules/.cache/eslint.

@askoufis askoufis requested a review from a team as a code owner November 8, 2024 03:50
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 92b0943

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis enabled auto-merge (squash) November 14, 2024 04:00
@askoufis askoufis merged commit 166c0b0 into master Nov 14, 2024
4 checks passed
@askoufis askoufis deleted the fix-lint-format branch November 14, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants