Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Support "Completed Order" #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support "Completed Order" #39

wants to merge 1 commit into from

Conversation

srthurman
Copy link

Support the legacy "Completed Order" event name. Some customers still use that, and this change will allow them to use Optimizely as intended without changing their code base.

Support the legacy "Completed Order" event name. Some customers still use that, and this change will allow them to use Optimizely as intended without changing their code base.
@srthurman srthurman requested a review from ladanazita September 7, 2017 20:56
@codecov-io
Copy link

codecov-io commented Sep 7, 2017

Codecov Report

Merging #39 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #39      +/-   ##
=========================================
- Coverage   98.11%   98.1%   -0.02%     
=========================================
  Files           1       1              
  Lines         159     158       -1     
=========================================
- Hits          156     155       -1     
  Misses          3       3
Impacted Files Coverage Δ
lib/index.js 98.1% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ab176...cdade68. Read the comment docs.

@Peripheral1994
Copy link
Contributor

Whoever deploys this, remember to bump package.json and the HISTORY.md accordingly. :)

@hankim813
Copy link
Contributor

@Peripheral1994 what happened to this? also might be better to just have .orderCompleted method vs catching all under .track() cc @ladanazita @jlee9595

@SegmentDestinationsBot
Copy link
Contributor

Hi @srthurman, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migrated The issue has been migrated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants