Skip to content

Commit

Permalink
chore!: Remove deprecated S3Store constructor (#502)
Browse files Browse the repository at this point in the history
  • Loading branch information
bhavanki authored May 30, 2024
1 parent cb4ed78 commit 8a469f8
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions store/s3store.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"errors"
"fmt"
"io/ioutil"
"os"
"sort"
"time"

Expand All @@ -19,8 +18,6 @@ import (

const (
MaximumVersions = 100
// deprecated
BucketEnvVar = "CHAMBER_S3_BUCKET"

latestObjectName = "__latest.json"
)
Expand Down Expand Up @@ -58,16 +55,6 @@ type S3Store struct {
bucket string
}

// Deprecated; use NewS3StoreWithBucket instead
func NewS3Store(numRetries int) (*S3Store, error) {
bucket, ok := os.LookupEnv(BucketEnvVar)
if !ok {
return nil, fmt.Errorf("Must set %s for s3 backend", BucketEnvVar)
}

return NewS3StoreWithBucket(numRetries, bucket)
}

func NewS3StoreWithBucket(numRetries int, bucket string) (*S3Store, error) {
config, _, err := getConfig(numRetries)
if err != nil {
Expand Down

0 comments on commit 8a469f8

Please sign in to comment.