chore!: Remove deprecated support for non-path SSM API #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.0 of chamber deprecated use of the non-path-based API for the SSM parameter store. This commit removes support for it completely. Since the deprecation occurred so long ago, this changeset does not preserve the ability to migrate to using the path-based API. Migration may be performed with a 2.x version of chamber prior to upgrading to a 3.x version.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 36.48% 35.81% -0.67%
==========================================
Files 25 25
Lines 2360 2284 -76
==========================================
- Hits 861 818 -43
+ Misses 1421 1394 -27
+ Partials 78 72 -6 ☔ View full report in Codecov by Sentry. |
bhavanki
changed the title
alecjacobs5401
approved these changes
Jun 4, 2024
| @@ -262,9 +262,8 @@ func matchStringFilters(filters []types.ParameterStringFilter, param mockParamet | |||
| return true, nil | |||
| } | |||
|
|
|||
| func NewTestSSMStore(parameters map[string]mockParameter, usePaths bool) *SSMStore { | |||
There was a problem hiding this comment.
I love how this test had a usePaths boolean argument but the actual code used a noPaths boolean argument. Twisted my brain right up!
There was a problem hiding this comment.
Oh geez, I don't know if I even noticed that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0 of chamber deprecated use of the non-path-based API for the
SSM parameter store. This commit removes support for it completely.
Since the deprecation occurred so long ago, this changeset does not
preserve the ability to migrate to using the path-based API. Migration
may be performed with a 2.x version of chamber prior to upgrading to
a 3.x version.
BREAKING CHANGE: Any users or clients still using the non-path-based SSM API will see errors working with the SSM parameter store.