feat: Add tag read, write, and delete commands #507
Conversation
The new commands are for reading, writing, and deleting tags on the underlying resources representing secrets. For now, the commands are only implemented for SSM parameters.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 36.17% 35.97% -0.20%
==========================================
Files 25 29 +4
Lines 2256 2524 +268
==========================================
+ Hits 816 908 +92
- Misses 1368 1538 +170
- Partials 72 78 +6 ☔ View full report in Codecov by Sentry. |
| ) | ||
|
|
||
| func init() { | ||
| tagWriteCmd.Flags().BoolVar(&deleteOtherTags, "delete-other-tags", false, "Delete tags not specified in the command") |
There was a problem hiding this comment.
This is a descriptive variable name, but I'm curious if there is precedent for CLIs to have an argument that is semantically the same but more conventional? Maybe --reset or --sync or --prune? Really not asking for a change just opening up a discussion about what a conventional flag someone might expect to exist on a CLI that has this behavior in a low surprise manner
There was a problem hiding this comment.
I didn't really do a survey, but I did ask OpenAI for suggestions and chose this 😆
There was a problem hiding this comment.
Hah! Funny. I asked open AI the same thing and it suggested those (specifically sync and prune) 😂
There was a problem hiding this comment.
I guess it depends on the question phrasing and OpenAI's mood that day!
The new commands are for reading, writing, and deleting tags on the
underlying resources representing secrets.
For now, the commands are only implemented for SSM parameters.