chore: Convert to log/slog #519
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
==========================================
- Coverage 36.44% 36.33% -0.11%
==========================================
Files 29 29
Lines 3257 3275 +18
==========================================
+ Hits 1187 1190 +3
- Misses 1983 1998 +15
Partials 87 87 ☔ View full report in Codecov by Sentry. |
|
slog was introduced in Go 1.21, so this cannot be integrated yet since chamber still supports go 1.20. I'll leave this PR inactive until the 1.23 release, which is expected in August (about 2 months from now). |
The small amount of verbose logging in the exec command has been converted to debug logging under log/slog.
| if verbose { | ||
| fmt.Fprintf(os.Stdout, "info: With environment %s\n", strings.Join(env, ",")) | ||
| } | ||
| slog.Debug(fmt.Sprintf("info: With environment %s\n", strings.Join(env, ","))) |
There was a problem hiding this comment.
is there any world where this is considered a breaking change? It looks like the comment in the help output for verbose before was wrong since partially we output to STDERR (only this line apparently was to STDOUT)
Do we need to keep that consistency for any reason?
|
@bhavanki Let's merge this |
The small amount of verbose logging in the exec command has been
converted to debug logging under log/slog.