support onCancel callback prop (#266)

segmentio · Jul 27, 2018 · 9000d62 · 9000d62
1 parent fb32b24
commit 9000d62
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/corner-dialog/src/CornerDialog.js b/src/corner-dialog/src/CornerDialog.js
@@ -161,6 +161,10 @@ export default class CornerDialog extends PureComponent {
     this.props.onCloseComplete()
   }
 
+  handleCancel = () => {
+    this.props.onCancel(this.handleClose)
+  }
+
   handleClose = () => {
     this.setState({ exiting: true })
   }
@@ -257,7 +261,7 @@ export default class CornerDialog extends PureComponent {
                     {confirmLabel}
                   </Button>
                   {hasCancel && (
-                    <Button onClick={this.handleClose}>{cancelLabel}</Button>
+                    <Button onClick={this.handleCancel}>{cancelLabel}</Button>
                   )}
                 </Pane>
               )}

diff --git a/src/dialog/src/Dialog.js b/src/dialog/src/Dialog.js
@@ -199,6 +199,7 @@ class Dialog extends React.Component {
       hasCancel,
       onCloseComplete,
       onOpenComplete,
+      onCancel,
       onConfirm,
       confirmLabel,
       isConfirmLoading,
@@ -276,7 +277,7 @@ class Dialog extends React.Component {
                   <Pane padding={16} float="right">
                     {/* Cancel should be first to make sure focus gets on it first. */}
                     {hasCancel && (
-                      <Button tabIndex={0} onClick={close}>
+                      <Button tabIndex={0} onClick={() => onCancel(close)}>
                         {cancelLabel}
                       </Button>
                     )}