Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sasl reauthentication #1230

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: sasl reauthentication #1230

wants to merge 3 commits into from

Conversation

ertanden
Copy link

Fixes #1093

Not really familiar with the code base, but I figured out that there are 2 different implementation of the Kafka protocol, so I put the same logic to both "conn.go" and "transport.go".

So far I could only test this with the "Reader" so the code in "conn.go" seems to work.

I tried different percentages, but ended up using a random %80-%90 percent of session lifetime to trigger re-authentication. A static %90 sometimes caused the "stopped heartbeat" problem with rebalances etc...

@whirlp00l
Copy link

any chance this got review?

@renanrt
Copy link

renanrt commented Mar 3, 2024

Hello, this PR would be important for us too, can someone review it?

@gurusiddha
Copy link

Hi team, can someone please review this PR? We are observing frequent rebalances into our consumer groups because of this issue.

@lmppalone
Copy link

Hi @petedannemann any update on this PR?

@lmhuteshmahajan
Copy link

Hi @petedannemann
Could someone please review this PR? We are experiencing frequent rebalances in our consumer groups due to this issue.
cc: @ertanden

@lmvaibhavshewale
Copy link

@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups

1 similar comment
@lmvaibhavshewale
Copy link

@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups

@billcobbler
Copy link

+1 for waiting on this to get merged. I see there's a required opa policy validation merge check, is that waiting on action from @ertanden to accept a contribution agreement or something before this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observing "Group Authorization Failed" error for every 12 hours
9 participants