-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sasl reauthentication #1230
base: main
Are you sure you want to change the base?
Conversation
feat: implement kip-368 for sasl reauthentication
any chance this got review? |
Hello, this PR would be important for us too, can someone review it? |
Hi team, can someone please review this PR? We are observing frequent rebalances into our consumer groups because of this issue. |
Hi @petedannemann any update on this PR? |
Hi @petedannemann |
@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups |
1 similar comment
@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups |
+1 for waiting on this to get merged. I see there's a required |
Fixes #1093
Not really familiar with the code base, but I figured out that there are 2 different implementation of the Kafka protocol, so I put the same logic to both "conn.go" and "transport.go".
So far I could only test this with the "Reader" so the code in "conn.go" seems to work.
I tried different percentages, but ended up using a random %80-%90 percent of session lifetime to trigger re-authentication. A static %90 sometimes caused the "stopped heartbeat" problem with rebalances etc...