PartitionEoF error in the reader #1257
Conversation
|
The tests are failing with the Request Timed Out, my local tests were failing like that too. However, it seems that my added test passes. Any advice? |
glossd
force-pushed
the
enable-partition-eof
branch
3 times, most recently
from
b8bbcea
to
8aea25f
Compare
|
@petedannemann Hi, I fixed the tests, but some of them are failing from time to time due to Request Timed Out error. I believe this is the issue Flaky tests . Could you please review? |
glossd
force-pushed
the
enable-partition-eof
branch
from
8aea25f
to
eb9d9ac
Compare
|
@petedannemann @ssingudasu Hello, could you please review this PR? I need this functionality for my project, and unlike sarama and confluent, this library doesn't have it. Or at least let me know if you're not going to review this. |
Just fork the repo for now to unblock yourself. We have a very lean team with limited capacity and cannot spend much time at our jobs reviewing open source contributions from outside contributors. We will get to this when we can find time for it |
This PR enables
Readerto notify the user when it reaches the end.This is the same functionality as in librdkafka with config
enable.partition.eof