Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke workspace deletion request feature #7372

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Added info to the billing/privacy pages about the new workspace deletion request feature.

Merge timing

asap!!

Related issues (optional)

@forstisabella forstisabella added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jan 8, 2025
@forstisabella forstisabella requested a review from a team as a code owner January 8, 2025 20:52
@forstisabella forstisabella requested a review from pwseg January 8, 2025 20:52
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 11d8644
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/67855477286046000831397f
😎 Deploy Preview https://deploy-preview-7372--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pwseg
pwseg previously approved these changes Jan 9, 2025
@pwseg
Copy link
Contributor

pwseg commented Jan 9, 2025

@forstisabella I didn't go through all the steps of deleting a workspace to reproduce this. Does the phrase "cool-off period" appear in the app anywhere? do we need to more clearly define what that means?

@forstisabella
Copy link
Contributor Author

@forstisabella I didn't go through all the steps of deleting a workspace to reproduce this. Does the phrase "cool-off period" appear in the app anywhere? do we need to more clearly define what that means?

yeah good point - it doesn't appear in the app. I'll remove that term!

src/guides/usage-and-billing/account-management.md Outdated Show resolved Hide resolved
src/guides/usage-and-billing/account-management.md Outdated Show resolved Hide resolved
src/privacy/account-deletion.md Outdated Show resolved Hide resolved
src/privacy/account-deletion.md Outdated Show resolved Hide resolved
pwseg
pwseg previously approved these changes Jan 9, 2025
@aparna879 aparna879 merged commit c62e461 into develop Jan 16, 2025
4 checks passed
@aparna879 aparna879 deleted the workspace-deletion-revokation branch January 16, 2025 15:35
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants