Ssingudasu/bug fix conn timeout flag (#203)

* Bug fix conn timeout for cluster config * Bug fix conn timeout for cluster config
segmentio · Jun 14, 2024 · 17d49c2 · 17d49c2
1 parent 757a906
commit 17d49c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/cmd/topicctl/subcmd/shared.go b/cmd/topicctl/subcmd/shared.go
@@ -125,6 +125,7 @@ func (s sharedOptions) getAdminClient(
 				UsernameOverride:          s.saslUsername,
 				PasswordOverride:          s.saslPassword,
 				SecretsManagerArnOverride: s.saslSecretsManagerArn,
+				KafkaConnTimeout:          s.connTimeout,
 			},
 		)
 	} else if s.brokerAddr != "" {

diff --git a/pkg/config/cluster.go b/pkg/config/cluster.go
@@ -203,6 +203,7 @@ type AdminClientOpts struct {
 	UsernameOverride          string
 	PasswordOverride          string
 	SecretsManagerArnOverride string
+	KafkaConnTimeout          time.Duration
 }
 
 // NewAdminClient returns a new admin client using the parameters in the current cluster config.
@@ -268,6 +269,7 @@ func (c ClusterConfig) NewAdminClient(
 						Password:          saslPassword,
 						SecretsManagerArn: secretsManagerArn,
 					},
+					ConnTimeout: opts.KafkaConnTimeout,
 				},
 				ExpectedClusterID: c.Spec.ClusterID,
 				ReadOnly:          opts.ReadOnly,
@@ -284,6 +286,7 @@ func (c ClusterConfig) NewAdminClient(
 				ExpectedClusterID: c.Spec.ClusterID,
 				Sess:              sess,
 				ReadOnly:          opts.ReadOnly,
+				KafkaConnTimeout:  opts.KafkaConnTimeout,
 			},
 		)
 	}