[EVM] Add tx replacement #1192

stevenlanders · 2023-12-28T14:57:18Z

Describe your changes and provide context

EVM transactions populate sender with a pattern {address}|{nonce}
The sender is used to de-dupe in the mempool (sei-tendermint)
A replacement transaction must have a higher priority number to replace (else reject)
Waiting on this PR: [EVM] Add evm tx replacement logic sei-tendermint#177

Testing performed to validate your change

sei-tendermint mempool unit tests

* evm wip * Create EVM module and add types/keeper * lint * rebase * tests * add tests * address comments

* evm wip * Create EVM module and add types/keeper * add tests * EVM signature verification * refactor

* [EVM] Add gas check ante handler * add tests and remove unnecessary configs/versions

* [EVM] implement balance related methods for state interface * add tests

) * Add account state to EVM state interface implementation * add Snapshot and rollback

* [EVM] Add gas check ante handler * [EVM] implement balance related methods for state interface * Add account state to EVM state interface implementation * add Snapshot and rollback * wip * [EVM] add remaining state interface function * rebase

* Add account state to EVM state interface implementation * add Snapshot and rollback * wip * [EVM] add remaining state interface function * [EVM] access list * add unit tests * improve code coverage --------- Co-authored-by: Jeremy Wei <[email protected]>

* [EVM] implement message server that processes EVM transactions * add tests

* [EVM] implement message server that processes EVM transactions * [EVM] add bank precompile * upgrade to Go 1.20 * rename coinbase * tests & linter

* [EVM] implement message server that processes EVM transactions * rename coinbase * [EVM] add RPC/WS server helpers * tests * fix

* [EVM] implement message server that processes EVM transactions * rename coinbase * [EVM] add RPC/WS server helpers * tests * wip * [EVM] add getBlockByHash endpoint * rebase

[EVM] getBlockByNumber

[EVM] add endpoint to get block transaction count

* [EVM] add get transaction receipt endpoint * refactor tests

[EVM] add getTransaction endpoints

[EVM] refactor gas logic

* [EVM] add endpoint to return fee history * bump to 1.21

* Implement get code, storage, balance endpoints * revert logging change * also using bank keeper to check for balances * appease linter

* simulate api * add tests * linter

* [EVM] add subscription utility * finished new filter * finished tests for new filter * finished uninstall filter * query tendermint for events * in progress * got first couple of tests done * finished tests for get logs * get filter logs and get filter changes * refactor * get filter logs accepts multiple addresses * use multiple addresses and use cursor map * remove bad test * remove prints and todos * minor fix * fix lint errors and failing test * poc to pass filtercriteria into JSON RPC * made topics 2d array and adjusted regex * GetLogs tests work * Finished other functions * remove unncessary inputs from NewFilterAPI * add expiration/timeouts for filters * removed error from UninstallFilter * minor fix * appease linter --------- Co-authored-by: codchen <[email protected]>

* [EVM] return gas info in message handler correctly * add comments

* integration * fix tests

* [EVM] add transaction type to associate account * tests

* [EVM] add transaction type to associate account * [EVM] convert balance decimal points * [EVM] add ACL dependencies for EVM transactions * Revert "[EVM] add ACL dependencies for EVM transactions" This reverts commit 5376a87. * address comments

* [EVM] several bug fixes * tests * add CheckTx nonce handling

* [EVM] several bug fixes * [EVM] add wasmd precompiles * [EVM] wasmd precompile * query method * add tests

* added new block filter * wip * finished tests * minor fix * fix lint * minor fix * added basic endpoint and created sendWSRequestAndListen * no goroutine in test * removed params * able to call my subscribe endpoint * subscribe2 works but not subscribe * got back msg from ws but hard to decode * subscription api uses sub manager, manager thread safe * able to send many messages through ws conn * newHeads tests work * newHeads works * subscribe works need to cleanup * test with multiple addrs, remove prints * cleanup * cleanup * fix test * fix linter * fix linter 2 * fix linter 3 * address comments * add unsubscribe in mock client * fix linter 4 * fix extra subscribe param * fix test

* [EVM] handle nonce gap in CheckTx * disable compatibility check

* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix

…1159) * able to txn deployment to go through * cleanup * remove prints * remove prints * fix linter * minor fix

…ns (#1158) * [EVM] add granular dependency * [EVM] define granular dependency

* Slow config for SendRawTransaction * fixes * fix test

* ERC721 * [EVM] add ERC721 template contract * use whitelisted send * add tests

* [EVM] Sign and Accounts endpoints * add SendTransaction * add nonce check * Revert "add nonce check" This reverts commit 83c7108. * add nonce check in Exists

* fix logs * Fix log endpoint

fix empty uncle hash

* Fix getTxByHash for pending txs * set tx index * bump tm * retry

* [EVM] show bank send in GetBlock response * add utilities

* Add basic checks * multiple fixes * fix race condition

codecov · 2023-12-28T15:06:55Z

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (0580149) 66.17% compared to head (0cbead3) 65.76%.
Report is 2 commits behind head on evm.

❗ Current head 0cbead3 differs from pull request most recent head 88e3864. Consider uploading reports for the commit 88e3864 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              evm    #1192      +/-   ##
==========================================
- Coverage   66.17%   65.76%   -0.42%     
==========================================
  Files         329      329              
  Lines       21536    21563      +27     
==========================================
- Hits        14252    14181      -71     
- Misses       6509     6610     +101     
+ Partials      775      772       -3

Files	Coverage Δ
x/evm/types/message_evm_transaction.go	`17.07% <0.00%> (-1.35%)`	⬇️
app/abci.go	`49.27% <0.00%> (-26.29%)`	⬇️

... and 3 files with indirect coverage changes

codchen · 2023-12-28T16:31:45Z

app/abci.go

+	}
+
+	// For EVM, populate sender on the response so that mempool can decide to dedupe
+	tx, err := app.txDecoder(req.Tx)


decoding (and the addr recovery logic below) is quite heavy so ideally we don't repeat it here. One other option is to a new field in sdk.Context, set it in the sig antehandler (where we derive address), and set it in checkTx response in sei-cosmos:baseapp:runTx.

But for now I think this is okay, since CheckTx itself doesn't directly affect chain performance

codchen and others added 30 commits September 21, 2023 17:52

Add EVM module & types/keeper (#1052)

dc3b332

* evm wip * Create EVM module and add types/keeper * lint * rebase * tests * add tests * address comments

EVM ante handler for signature verification (#1059)

82c4be4

* evm wip * Create EVM module and add types/keeper * add tests * EVM signature verification * refactor

[EVM] Add gas check ante handler (#1067)

e71284a

* [EVM] Add gas check ante handler * add tests and remove unnecessary configs/versions

[EVM] implement balance related methods for state interface (#1068)

dc0f028

* [EVM] implement balance related methods for state interface * add tests

Add state-related function implementations in EVM state interface (#1071

4fc5e43

) * Add account state to EVM state interface implementation * add Snapshot and rollback

[EVM] implement message server that processes EVM transactions (#1083)

cc07dbf

* [EVM] implement message server that processes EVM transactions * add tests

update linter (#1060) (#1092)

3efee16

[EVM] add bank precompile (#1088)

ac2f910

* [EVM] implement message server that processes EVM transactions * [EVM] add bank precompile * upgrade to Go 1.20 * rename coinbase * tests & linter

[EVM] add API platform (#1093)

48391f0

* [EVM] implement message server that processes EVM transactions * rename coinbase * [EVM] add RPC/WS server helpers * tests * fix

[EVM] RPC endpoint getBlockByHash (#1094)

0eaea1c

* [EVM] implement message server that processes EVM transactions * rename coinbase * [EVM] add RPC/WS server helpers * tests * wip * [EVM] add getBlockByHash endpoint * rebase

[EVM] add getBlockByNumber endpoint (#1098)

931e7ec

[EVM] getBlockByNumber

[EVM] add endpoints to get block transaction count (#1099)

a5a116d

[EVM] add endpoint to get block transaction count

[EVM] add getTransactionReceipt (#1100)

8ea91fe

* [EVM] add get transaction receipt endpoint * refactor tests

[EVM] add getTransactions endpoints (#1101)

2e7be7a

[EVM] add getTransaction endpoints

[EVM] add endpoint to get transaction count by address (#1103)

87130e6

[EVM] fix gas logic (#1104)

fa324c1

[EVM] refactor gas logic

[EVM] add endpoint to return fee history (#1106)

2f3ef35

* [EVM] add endpoint to return fee history * bump to 1.21

[EVM] add info endpoints (#1107)

2cc2a74

[EVM] eth state endpoints (#1105)

fb337b3

* Implement get code, storage, balance endpoints * revert logging change * also using bank keeper to check for balances * appease linter

[EVM] add subscription utility (#1109)

c9cc4a0

[EVM] add endpoint to send transaction (#1108)

fc9f6f7

[EVM] get simulation endpoints (#1110)

7120e9d

* simulate api * add tests * linter

[EVM] add getProof endpoint (#1114)

68e65c4

[EVM] return gas info in message handler correctly (#1115)

841847e

* [EVM] return gas info in message handler correctly * add comments

EVM Module Integration (#1122)

df1753f

* integration * fix tests

[EVM] add transaction type to associate account (#1126)

20edb22

* [EVM] add transaction type to associate account * tests

codchen and others added 24 commits November 13, 2023 13:20

[EVM] several bug fixes (#1136)

7934261

* [EVM] several bug fixes * tests * add CheckTx nonce handling

[EVM] add wasmd precompile (#1139)

c80fa34

* [EVM] several bug fixes * [EVM] add wasmd precompiles * [EVM] wasmd precompile * query method * add tests

[EVM] add bank metadata precompile functions (#1140)

1c33db0

[EVM] handle gapped nonce in CheckTx (#1142)

454eba5

* [EVM] handle nonce gap in CheckTx * disable compatibility check

[EVM] fix getProof (#1145)

9d7c401

[EVM] add deps for EVM ante handlers (#1149)

09887d9

[EVM] denormalize intermediary and coinbase accounts (#1153)

716a0b2

[EVM] seid command to deploy erc20 contract for a native sei token (#…

8bd3a45

…1159) * able to txn deployment to go through * cleanup * remove prints * remove prints * fix linter * minor fix

[EVM] preprocess EVM transactions and define granular access operatio…

cff9f16

…ns (#1158) * [EVM] add granular dependency * [EVM] define granular dependency

[EVM] --slow config for send raw txn (#1165)

f4ea986

* Slow config for SendRawTransaction * fixes * fix test

[EVM] add ERC-721 -> CW-721 interoperability contract (#1162)

122ae3c

* ERC721 * [EVM] add ERC721 template contract * use whitelisted send * add tests

[EVM] allow passing in private key hex for address association (#1166)

33116aa

[EVM] Sign and Accounts endpoints (#1167)

057f37e

* [EVM] Sign and Accounts endpoints * add SendTransaction * add nonce check * Revert "add nonce check" This reverts commit 83c7108. * add nonce check in Exists

bump base geth version (#1172)

d08a479

Use pending transactions to handle higher nonce txs gracefully (#1175)

d048f8c

[EVM] fix logs disappearing issue (#1178)

c124d4a

* fix logs * Fix log endpoint

Use better error message (#1179)

64a5f79

Fix empty uncle hash (#1183)

a7e8d10

fix empty uncle hash

Fix getTxByHash for pending txs (#1181)

b3a5a7e

* Fix getTxByHash for pending txs * set tx index * bump tm * retry

[EVM] show bank send in GetBlock response (#1187)

b5362ae

* [EVM] show bank send in GetBlock response * add utilities

[EVM] add stateless checks (#1188)

0580149

* Add basic checks * multiple fixes * fix race condition

add tx replacement

306971d

fix lint

0cbead3

codchen reviewed Dec 28, 2023

View reviewed changes

stevenlanders added 2 commits December 29, 2023 12:34

update nonce/address injection

fcccead

fix issue with sending non-legacy txs

88e3864

codchen force-pushed the evm branch from 2edefc4 to a1e083e Compare January 8, 2024 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EVM] Add tx replacement #1192

[EVM] Add tx replacement #1192

stevenlanders commented Dec 28, 2023 •

edited

Loading

codecov bot commented Dec 28, 2023 •

edited

Loading

codchen Dec 28, 2023

[EVM] Add tx replacement #1192

Are you sure you want to change the base?

[EVM] Add tx replacement #1192

Conversation

stevenlanders commented Dec 28, 2023 • edited Loading

Describe your changes and provide context

Testing performed to validate your change

codecov bot commented Dec 28, 2023 • edited Loading

Codecov Report

codchen Dec 28, 2023

Choose a reason for hiding this comment

stevenlanders commented Dec 28, 2023 •

edited

Loading

codecov bot commented Dec 28, 2023 •

edited

Loading