EVM Precompile integration test #1379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## evm #1379 +/- ##
==========================================
+ Coverage 63.16% 63.27% +0.11%
==========================================
Files 350 350
Lines 23760 23760
==========================================
+ Hits 15008 15035 +27
+ Misses 7896 7864 -32
- Partials 856 861 +5 |
Kbhat1
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## evm #1379 +/- ##
==========================================
- Coverage 63.16% 63.03% -0.13%
==========================================
Files 350 350
Lines 23760 23760
==========================================
- Hits 15008 14978 -30
- Misses 7896 7923 +27
- Partials 856 859 +3 |
jewei1997
commented
Mar 14, 2024
jewei1997
commented
Mar 14, 2024
|
make sure you merge to |
jewei1997
commented
Mar 14, 2024
| expect(diff).to.equal(1); | ||
| }); | ||
|
|
||
| it("Approve and TransferFrom functions", async function() { |
There was a problem hiding this comment.
can you do a transferFrom without doing an approve and make sure it fails?
jewei1997
commented
Mar 14, 2024
| console.log("end of before"); | ||
| }); | ||
|
|
||
| it("Transfer function", async function() { |
There was a problem hiding this comment.
can we do a transfer from an address with no token balance and make sure it fails
Kbhat1
force-pushed
the
evm-bank-precompile-integration-test
branch
from
f3122e3 to
b7bb3a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change
seilocalhardhat runnpx hardhat test --network seilocal test/EVMPrecompileTester.js