Use tendermint store to get Tx hashes instead of storing explicitly #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
approved these changes
Oct 30, 2024
evmrpc/block.go
Outdated
Comment on lines
158
to
174
| for i, tx := range block.Block.Data.Txs { | ||
| sdkTx, err := a.txConfig.TxDecoder()(tx) | ||
| if err != nil { | ||
| fmt.Printf("error decoding tx %d in block %d, skipping\n", i, height) | ||
| continue | ||
| } | ||
| if len(sdkTx.GetMsgs()) == 0 { | ||
| continue | ||
| } | ||
| if evmTx, ok := sdkTx.GetMsgs()[0].(*types.MsgEVMTransaction); ok { | ||
| if evmTx.IsAssociateTx() { | ||
| continue | ||
| } | ||
| ethtx, _ := evmTx.AsTransaction() | ||
| txHashes = append(txHashes, ethtx.Hash()) | ||
| } | ||
| } |
There was a problem hiding this comment.
nit - shoudl we consider moving this to a helper function so it can be reused in filter.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
EVM Tx hashes are used for certain EVM RPC queries. Storing EVM Tx hashes explicitly as app state has been causing state bloat. This information is actually already stored in Tendermint block store. This PR changes relevant RPC endpoints to read from Tendermint instead of hashes in app state. Once we are confident that the change is not interruptive to current use cases out there, we can remove the tx hash writing logic and delete the app state.
Testing performed to validate your change
existing unit test should still work