Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IBC precompile nonpayable #2032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make IBC precompile nonpayable #2032

wants to merge 1 commit into from

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Jan 10, 2025

Describe your changes and provide context

Make IBC precompile nonpayable. It was defined as such in solidity, but not in ABI + added enforcement in code.

Testing performed to validate your change

  • unit test

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (223a234) to head (abaa75e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   61.47%   61.50%   +0.02%     
==========================================
  Files         264      264              
  Lines       24565    24568       +3     
==========================================
+ Hits        15101    15110       +9     
+ Misses       8335     8328       -7     
- Partials     1129     1130       +1     
Files with missing lines Coverage Δ
precompiles/ibc/ibc.go 47.31% <100.00%> (+0.53%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant