Add EVM support #221
Add EVM support #221
Conversation
|
This is pretty cool! Does adding EVM & WASM support in the same app significantly increase strain on existing validator set-ups/add complexity at the app-layer by needing to have support for ERC-20s & cw20s? |
Hey! Good question. We're still looking into this, since we ultimately would like to support Solidity < > Cosmwasm compatibility. That will likely be addressed in a separate PR |
Yeah makes sense, integrating cw & erc-20 in tokenfactory feels like a great place to start When the PR comes out would be great if you could link bc would love to take a look |
|
|
||
| // Ethermint keepers | ||
| EvmKeeper *evmkeeper.Keeper | ||
| FeeMarketKeeper feemarketkeeper.Keeper |
There was a problem hiding this comment.
how does the feemarket module interact with the original gas fee system here?
There was a problem hiding this comment.
This is for allowing for variable fee for Cosmos txns so that it behaves similarly to EIP-1559: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md
Do you think it makes sense to remove it and keep the original gas fee mechanism? \cc @codchen
There was a problem hiding this comment.
we can discuss this in a separate ticket^
|
|
||
| ############################################################################### | ||
| ### JSON RPC Configuration ### | ||
| ############################################################################### |
There was a problem hiding this comment.
why do we put this in the root.go instead of the params store (from genesis.json)
There was a problem hiding this comment.
I'm not sure what you mean? Do you mind clarifying?
| @@ -126,20 +133,27 @@ func initRootCmd( | |||
| ) | |||
|
|
|||
| // add server commands | |||
| server.AddCommands( | |||
There was a problem hiding this comment.
do we also need the sdkserver.AddCommands here to keep seid command working
There was a problem hiding this comment.
nope, basically ethermintserver.AddCommands is a superset of server.AddCommands, but includes necessary ones for evm. See https://github.com/evmos/ethermint/blob/main/server/util.go#L24
Note that it has sdkserver which is what we have here as server
| ) (newCtx sdk.Context, err error) { | ||
| var anteHandler sdk.AnteHandler | ||
|
|
||
| defer Recover(ctx.Logger(), &err) |
There was a problem hiding this comment.
do we want to remove the panic-recover here? we properly want to avoid recover panic as that may hide more severe bugs (and we may not be able to monitor this each time)
There was a problem hiding this comment.
this is a good question. I think it doesn't make sense for a single txn to bring down the whole chain though. Ill think it makes sense to add monitoring though
There was a problem hiding this comment.
yea the thing i'm worried about is this may hide err and make the chain get into a corrupted state. I'm aligned with having this on testnet + monitor, and remove before mainnet
| return nil, err | ||
| } | ||
|
|
||
| return func( |
There was a problem hiding this comment.
is it possible to return built EthAnteHandler & CosmosAnteHandler map here? or register ethAnteHandler to the cosmos ante decorator? returning a func here seems to make each tx creates a new AnteHandler here
There was a problem hiding this comment.
good point. Done!
| ) (newCtx sdk.Context, err error) { | ||
| var anteHandler sdk.AnteHandler | ||
|
|
||
| defer Recover(ctx.Logger(), &err) |
There was a problem hiding this comment.
yea the thing i'm worried about is this may hide err and make the chain get into a corrupted state. I'm aligned with having this on testnet + monitor, and remove before mainnet
|
|
||
| // Ethermint keepers | ||
| EvmKeeper *evmkeeper.Keeper | ||
| FeeMarketKeeper feemarketkeeper.Keeper |
There was a problem hiding this comment.
we can discuss this in a separate ticket^
|
Leave open, we will revist soon |
Description
Note: Please review this since the last commit introduces a lot of fmt changes
Add EVM support to SEI via ethermint module: https://github.com/evmos/ethermint
Essentially this PR replaces a lot of the scaffolding done by ignite to use ethermint instead of cosmos-sdk (e.g. https://github.com/sei-protocol/sei-chain/pull/221/files#diff-5b0b558d0a19d57e79af24fcfd5b1b099ced2eb2fe4447402069c892813478e9R11). Also created a 1-click init.sh file to run sei locally (with sane configs).
EVM support added are:
secp256k1andeth_secp256k1signaturescommands for
seid keysTesting