Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive Denom as Query String in Req #518

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Receive Denom as Query String in Req #518

wants to merge 3 commits into from

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Jun 14, 2024

Describe your changes and provide context

Testing performed to validate your change

  • Verifying on node
  • Added unit tests

@Kbhat1 Kbhat1 changed the title Receive arg as Query String in Req Receive Denom as Query String in Req Jun 14, 2024
@Kbhat1 Kbhat1 requested review from codebycarson and besated June 14, 2024 20:22
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 55.30%. Comparing base (bf9783f) to head (97cf445).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   55.31%   55.30%   -0.01%     
==========================================
  Files         631      631              
  Lines       54226    54237      +11     
==========================================
+ Hits        29993    29994       +1     
- Misses      22089    22099      +10     
  Partials     2144     2144              
Files Coverage Δ
x/bank/keeper/grpc_query.go 44.96% <0.00%> (-3.59%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants