Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix closer assignment #536

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix closer assignment #536

merged 1 commit into from
Aug 28, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Aug 28, 2024

Describe your changes and provide context

This properly assigns closers when adding them so that scStore is properly closed after statesync snapshot.

Testing performed to validate your change

Verified on statesyncer node in arctic-1

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (f364e37) to head (de6f159).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
store/cachemulti/store.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files         631      631           
  Lines       54807    54807           
=======================================
+ Hits        30052    30055    +3     
+ Misses      22603    22601    -2     
+ Partials     2152     2151    -1     
Files with missing lines Coverage Δ
store/cachemulti/store.go 6.83% <0.00%> (ø)

... and 1 file with indirect coverage changes

@udpatil udpatil merged commit 947de5a into main Aug 28, 2024
14 of 15 checks passed
@udpatil udpatil deleted the fix-sc-close branch August 28, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants