-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token allow list feature. Bank module changes #538
Conversation
- persist allow list - check allow list on send
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 54.83% 54.88% +0.05%
==========================================
Files 631 631
Lines 54808 54899 +91
==========================================
+ Hits 30052 30132 +80
- Misses 22604 22612 +8
- Partials 2152 2155 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
if err != nil { | ||
return err | ||
} | ||
allowedToReceive := k.IsAllowedToSendCoins(ctx, outAddress, out.Coins, denomToAllowListCache) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it intended to use the same IsAllowedToSendCoins
for receiver validation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was going on naming back and forth. But the same method is used for both sender and receiver validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has one nit but overall lgtm
…tion to support minting for tokenfactory tokens as tokens are sent from the module address
Describe your changes and provide context
This change is part of token allow list feature implementation for token extensions.
Added functions to:
from
andto
addresses are in allowlist on bank send and multi-sendTesting performed to validate your change