Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Node Migration: Expose Get State Store + Query Iavl Before Migration Height #541

Merged
merged 10 commits into from
Oct 29, 2024

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Sep 23, 2024

Describe your changes and provide context

  • Exposes GetStateStore from rootmulti
  • For historical queries, if before migration height, points to iavl

Testing performed to validate your change

  • Verified and tested on node

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 39.53488% with 26 lines in your changes missing coverage. Please review.

Project coverage is 54.89%. Comparing base (4e7d467) to head (468f8dc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
baseapp/abci.go 62.96% 7 Missing and 3 partials ⚠️
baseapp/baseapp.go 0.00% 6 Missing and 2 partials ⚠️
baseapp/options.go 0.00% 4 Missing ⚠️
storev2/rootmulti/store.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   54.90%   54.89%   -0.01%     
==========================================
  Files         631      631              
  Lines       54920    54955      +35     
==========================================
+ Hits        30152    30166      +14     
- Misses      22614    22631      +17     
- Partials     2154     2158       +4     
Files with missing lines Coverage Δ
baseapp/options.go 46.78% <0.00%> (-1.13%) ⬇️
storev2/rootmulti/store.go 2.60% <0.00%> (-0.01%) ⬇️
baseapp/baseapp.go 65.66% <0.00%> (-0.68%) ⬇️
baseapp/abci.go 52.79% <62.96%> (+0.27%) ⬆️

yzang2019 and others added 2 commits September 24, 2024 23:13
## Describe your changes and provide context
This PR add an extra QMS used for serving online migration query
fallback. When the request height is lower than the migration height, we
will fall back to read from IAVL store, otherwise, it will use the
default CMS

## Testing performed to validate your change
@Kbhat1 Kbhat1 changed the title Expose Get State Store Archive Node Migration: Expose Get State Store + Query Iavl Before Migration Height Oct 17, 2024
@Kbhat1 Kbhat1 enabled auto-merge (squash) October 29, 2024 18:23
@Kbhat1 Kbhat1 merged commit 851b25b into main Oct 29, 2024
14 of 15 checks passed
@Kbhat1 Kbhat1 deleted the ArchiveNodeMigrationOnline branch October 29, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants