Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QMS for IAVL migration query multistore #542

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

yzang2019
Copy link
Collaborator

Describe your changes and provide context

This PR add an extra QMS used for serving online migration query fallback. When the request height is lower than the migration height, we will fall back to read from IAVL store, otherwise, it will use the default CMS

Testing performed to validate your change

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (d73f5bc) to head (dfd3a4f).
Report is 2 commits behind head on ArchiveNodeMigrationOnline.

Files with missing lines Patch % Lines
baseapp/abci.go 54.16% 7 Missing and 4 partials ⚠️
baseapp/options.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           ArchiveNodeMigrationOnline     #542      +/-   ##
==============================================================
- Coverage                       54.88%   54.87%   -0.02%     
==============================================================
  Files                             631      631              
  Lines                           54904    54925      +21     
==============================================================
+ Hits                            30135    30140       +5     
- Misses                          22615    22627      +12     
- Partials                         2154     2158       +4     
Flag Coverage Δ
54.87% <46.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
baseapp/baseapp.go 65.15% <ø> (ø)
baseapp/options.go 46.78% <0.00%> (-1.13%) ⬇️
baseapp/abci.go 52.34% <54.16%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@Kbhat1 Kbhat1 changed the base branch from main to ArchiveNodeMigrationOnline September 25, 2024 03:12
@Kbhat1 Kbhat1 merged commit e618491 into ArchiveNodeMigrationOnline Sep 25, 2024
14 of 15 checks passed
@Kbhat1 Kbhat1 deleted the yzang/SEI-8116 branch September 25, 2024 03:13
Kbhat1 pushed a commit that referenced this pull request Oct 22, 2024
## Describe your changes and provide context
This PR add an extra QMS used for serving online migration query
fallback. When the request height is lower than the migration height, we
will fall back to read from IAVL store, otherwise, it will use the
default CMS

## Testing performed to validate your change
Kbhat1 pushed a commit that referenced this pull request Oct 29, 2024
## Describe your changes and provide context
This PR add an extra QMS used for serving online migration query
fallback. When the request height is lower than the migration height, we
will fall back to read from IAVL store, otherwise, it will use the
default CMS

## Testing performed to validate your change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants