Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply DeliverTx hooks if there is no error #544

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Oct 17, 2024

Describe your changes and provide context

Previously we only apply hooks if there is no error in DeliverTx response, which is changed by the refactor. This PR fixes it

Testing performed to validate your change

integration test in sei-chain

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (4e7d467) to head (5ba958e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   54.90%   54.90%           
=======================================
  Files         631      631           
  Lines       54920    54921    +1     
=======================================
+ Hits        30152    30153    +1     
  Misses      22614    22614           
  Partials     2154     2154           
Files with missing lines Coverage Δ
baseapp/baseapp.go 66.39% <100.00%> (+0.04%) ⬆️

@philipsu522 philipsu522 merged commit c7e50a2 into main Oct 22, 2024
15 checks passed
@philipsu522 philipsu522 deleted the only-apply-hooks-if-no-error branch October 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants