Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invariance check & logs to occ scheduler #545

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Oct 24, 2024

Describe your changes and provide context

Add logs where certain implicit invariants in OCC scheduler are broken

Testing performed to validate your change

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.91%. Comparing base (4e7d467) to head (0ec7b87).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tasks/scheduler.go 75.86% 5 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   54.90%   54.91%   +0.01%     
==========================================
  Files         631      631              
  Lines       54920    54946      +26     
==========================================
+ Hits        30152    30174      +22     
- Misses      22614    22617       +3     
- Partials     2154     2155       +1     
Files with missing lines Coverage Δ
store/multiversion/store.go 91.11% <100.00%> (+0.14%) ⬆️
tasks/scheduler.go 90.29% <75.86%> (-0.54%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant